Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: valuation for inert primes #1708

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: valuation for inert primes #1708

merged 1 commit into from
Dec 20, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Dec 20, 2024

  • also fix Hensel lifting in the trivial case

- also fix Hensel lifting in the trivial case
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (9f4ccb9) to head (1534667).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1708      +/-   ##
==========================================
+ Coverage   76.03%   76.04%   +0.01%     
==========================================
  Files         361      361              
  Lines      114336   114344       +8     
==========================================
+ Hits        86938    86958      +20     
+ Misses      27398    27386      -12     
Files with missing lines Coverage Δ
src/Misc/Poly.jl 69.78% <100.00%> (+0.35%) ⬆️
src/NumFieldOrd/NfOrd/Ideal/Valuation.jl 86.87% <100.00%> (+0.09%) ⬆️

... and 27 files with indirect coverage changes

@thofma thofma requested a review from fieker December 20, 2024 15:44
@thofma thofma merged commit 5444e71 into master Dec 20, 2024
18 checks passed
@thofma thofma deleted the th/fixhenselval branch December 20, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant